Tal Nisan has posted comments on this change. Change subject: core: Remove redundant Vds call at Add existingFileStorageDomain ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35108/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 54: if (DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId()) != null) { Line 55: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST); Line 56: } Line 57: Line 58: Pair<StorageDomainStatic, Guid> domainFromIrs = (Pair<StorageDomainStatic, Guid>) runVdsCommand( Please use executeHSMGetStorageDomainInfo - that's why you added it in the first place Line 59: VDSCommandType.HSMGetStorageDomainInfo, Line 60: new HSMGetStorageDomainInfoVDSCommandParameters(getVdsId(), getStorageDomain().getId()) Line 61: ).getReturnValue(); Line 62: if (domainFromIrs == null) { -- To view, visit http://gerrit.ovirt.org/35108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
