Eli Mesika has posted comments on this change. Change subject: core : Introduce engine_sessions table and DAO ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/35148/2/packaging/dbscripts/upgrade/03_06_0530_add_engine_sessions.sql File packaging/dbscripts/upgrade/03_06_0530_add_engine_sessions.sql: Line 1: CREATE TABLE engine_sessions ( Line 2: id character varying(255) NOT NULL, > not sure what is varying... can we hold here any utf8 string? won't it bett I don't think we need a SEQ here , as far as I know we will retrieve by the session id , so what is the point ? But I have another question , if this is a Guid as I see from the DAO impl code, why noy using a native UUID type ? Line 3: user_id uuid NOT NULL, Line 4: user_name character varying(255) NOT NULL, Line 5: group_ids text, Line 6: role_ids text, Line 2: id character varying(255) NOT NULL, Line 3: user_id uuid NOT NULL, Line 4: user_name character varying(255) NOT NULL, Line 5: group_ids text, Line 6: role_ids text, > can above two be null? Its the default when you don't explicitly declare it as "NOT NULL" Line 7: CONSTRAINT pk_engine_sessions PRIMARY KEY(id) -- To view, visit http://gerrit.ovirt.org/35148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
