Alon Bar-Lev has posted comments on this change.

Change subject: core : Introduce engine_sessions table and DAO
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35148/4/packaging/dbscripts/engine_sessions_sp.sql
File packaging/dbscripts/engine_sessions_sp.sql:

Line 1: ----------------------------------------------------------------
Line 2: -- [engine_sessions] Table
Line 3: --
Line 4: Create or replace FUNCTION InsertEngineSession(INOUT v_id INTEGER,
Line 5:         v_engine_session_id VARCHAR(255),
I would like this longer, please, so we have no issues, eli suggested text.
Line 6:         v_user_id UUID,
Line 7:         v_user_name VARCHAR(255),
Line 8:         v_group_ids VARCHAR(2048),
Line 9:         v_role_ids VARCHAR(2048))


-- 
To view, visit http://gerrit.ovirt.org/35148
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to