Eli Mesika has posted comments on this change. Change subject: db: add config key with same value to multiple versions ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35114/3/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 601: END; $procedure$ Line 602: LANGUAGE plpgsql; Line 603: Line 604: -- sets the v_val value for v_option_name in vdc_options for all versions before and up to v_version including v_version Line 605: create or replace FUNCTION fn_db_add_config_value_for_versions(v_option_name varchar(100), v_val varchar(4000), v_version varchar(40)) > Just a minor note, wouldn't fn_db_add_config_value_for_versions_up_to be a Done Line 606: returns void Line 607: AS $procedure$ Line 608: declare Line 609: m varchar; Line 606: returns void Line 607: AS $procedure$ Line 608: declare Line 609: m varchar; Line 610: arr varchar[] := array['3.0', '3.1', '3.2', '3.3', '3.4', '3.5', '3.6']; > Please add info here and to org.ovirt.engine.core.compat.Version that this done 3.6 for compat....vesion should be added in a separate patch Line 611: begin Line 612: FOREACH m IN ARRAY arr Line 613: LOOP Line 614: perform fn_db_add_config_value(v_option_name, v_val, m); -- To view, visit http://gerrit.ovirt.org/35114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I432038577c1e695d2821471a607ab842ea64c97b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
