Martin Peřina has posted comments on this change. Change subject: db: add config key with same value to multiple versions ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35114/3/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 606: returns void Line 607: AS $procedure$ Line 608: declare Line 609: m varchar; Line 610: arr varchar[] := array['3.0', '3.1', '3.2', '3.3', '3.4', '3.5', '3.6']; Please add info here and to org.ovirt.engine.core.compat.Version that this array and Version content should be in sync. Btw if 3.6 is here, we should add it also to Version, right? Line 611: begin Line 612: FOREACH m IN ARRAY arr Line 613: LOOP Line 614: perform fn_db_add_config_value(v_option_name, v_val, m); -- To view, visit http://gerrit.ovirt.org/35114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I432038577c1e695d2821471a607ab842ea64c97b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
