Oved Ourfali has posted comments on this change. Change subject: core: add keystone url field to external providers ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34880/4/packaging/dbscripts/upgrade/03_06_0520_add_authentication_url.sql File packaging/dbscripts/upgrade/03_06_0520_add_authentication_url.sql: Line 1: SELECT fn_db_add_column('providers', 'auth_url', 'TEXT DEFAULT NULL'); Line 2: Line 3: UPDATE providers set auth_url = (select option_value from vdc_options where option_name = 'KeystoneAuthUrl') Line 4: WHERE auth_required; > No clear decision about that yet I told you that it should be limited in our last discussion. It is not relevant at all for providers other than the two specified above. Line 5: Line 6: -- this must be done here since 0000_config.sql is running in the pre-upgrade stage Line 7: Line 8: select fn_db_delete_config_value('KeystoneAuthUrl','general'); -- To view, visit http://gerrit.ovirt.org/34880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1aa930cd8dec576a6408402dd883ab5162e1f9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches