Sandro Bonazzola has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/34940/4/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 516: return 'OVEHOSTED_STORAGE/iSCSILunId' Line 517: Line 518: ISCSI_PASSWORD = 'OVEHOSTED_STORAGE/iSCSIPortalPassword' Line 519: Line 520: BDEVICE_SIZE_GB = 'OVEHOSTED_STORAGE/bDeviceSizeGB' You can use full text here: OVEHOSTED_STORAGE/blockDeviceSizeGB Line 521: Line 522: @ohostedattrs( Line 523: answerfile=True, Line 524: ) http://gerrit.ovirt.org/#/c/34940/4/src/plugins/ovirt-hosted-engine-setup/vm/image.py File src/plugins/ovirt-hosted-engine-setup/vm/image.py: Line 94: # could be gathered from vginfo but at this point Line 95: # it still has to be created Line 96: available_gb = self.environment[ Line 97: ohostedcons.StorageEnv.BDEVICE_SIZE_GB Line 98: ] - ohostedcons.Const.OHD_OVERHEAD_GIB I suggest to use int() here. environment may be parsed as str Line 99: Line 100: valid = False Line 101: while not valid: Line 102: if interactive: -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
