Nir Soffer has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34940/1/src/plugins/ovirt-hosted-engine-setup/vm/image.py File src/plugins/ovirt-hosted-engine-setup/vm/image.py: Line 100: raise RuntimeError(vginfo['status']['message']) Line 101: vgfree = int(vginfo['info']['vgfree']) Line 102: vgmaxavailable = ( Line 103: vgfree / ohostedcons.Const.MINIMUM_SPACE_STORAGEDOMAIN_MB * Line 104: ohostedcons.Const.MINIMUM_SPACE_STORAGEDOMAIN_MB > vgavailable = vgfree / EXTENT_SIZE * EXTENT_SIZE, yes sorry :-) We cannot promised that, but if the extent size is smaller then 1GiB, multiple of GiB will always be correct. I don't see any reason to increase our extent size over 1GiB. Calculating using hardcoded extent size is less safer since it is more likely that we will change it, then change it over 1GiB. Line 105: ) Line 106: Line 107: valid = False Line 108: while not valid: -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
