Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: list models managed by GIN ......................................................................
Patch Set 15: (2 comments) Some more comments for patchset 15. http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalModule.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalModule.java: Line 28: import com.google.gwt.inject.client.AbstractGinModule; Line 29: import com.google.inject.Singleton; Line 30: import com.google.inject.TypeLiteral; Line 31: Line 32: public class UserPortalModule extends AbstractGinModule { Shouldn't bindings in this module be part of existing UiCommonModule? (Current UiCommonModule contains model provider bindings, it could also contain bindings for specific models too.) Line 33: Line 34: @Override Line 35: protected void configure() { Line 36: bind(AdElementListModel.class).to(UserPortalAdElementListModel.class); http://gerrit.ovirt.org/#/c/34193/15/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java: Line 290: } Line 291: Line 292: @Override Line 293: protected void configure() { Line 294: bind(ClusterListModel.class).in(Singleton.class); Great! I really like that bindings for specific cluster-related models are part of ClusterModule etc. - all related bindings are in one place. Line 295: bind(ClusterGeneralModel.class).in(Singleton.class); Line 296: bind(ClusterHostListModel.class).in(Singleton.class); Line 297: bind(ClusterNetworkListModel.class).in(Singleton.class); Line 298: bind(ClusterVmListModel.class).in(Singleton.class); -- To view, visit http://gerrit.ovirt.org/34193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2f8915203f4a2b9868767419351ef7ac702891 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
