Kanagaraj M has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/34552/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 72: refreshGeoRepSessionStatus(cluster, geoRepSessions); Line 73: } Line 74: Line 75: public void refreshGeoRepDataForVolume(final GlusterVolumeEntity volume) { Line 76: VDSGroup cluster = getClusterDao().get(volume.getClusterId()); Feature support check can be done here itself Line 77: discoverGeoRepDataForVolume(cluster, volume); Line 78: List<GlusterGeoRepSession> geoRepSessions = getGeoRepDao().getGeoRepSessions(volume.getId()); Line 79: refreshGeoRepSessionStatus(cluster, geoRepSessions); Line 80: } Line 130: if (!supportsGlusterGeoRepFeature(cluster)) { Line 131: return; Line 132: } Line 133: Line 134: if (volume == null) { This check should be done much earlier Line 135: throw new VdcBLLException(VdcBllErrors.GlusterVolumeGeoRepSyncFailed, "No volume information"); Line 136: } Line 137: Line 138: Map<String, GlusterGeoRepSession> sessionsMap = getSessionsFromCLI(cluster, volume.getName()); http://gerrit.ovirt.org/#/c/34552/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java: Line 118: public GlusterVolumeGeoRepStatusForXmlRpc(Map<String, Object> innerMap) { Line 119: this(innerMap, true); Line 120: } Line 121: Line 122: public GlusterVolumeGeoRepStatusForXmlRpc(Map<String, Object> innerMap, boolean process) { can we have a better name for 'process'? Line 123: super(innerMap); Line 124: if (process && innerMap.containsKey(GEO_REP)) { Line 125: populateSessions((Object[]) innerMap.get(GEO_REP)); Line 126: } -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
