Alon Bar-Lev has posted comments on this change. Change subject: core: Add JPA infrastructure to oVirt ......................................................................
Patch Set 15: (8 comments) http://gerrit.ovirt.org/#/c/33832/15/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 53: Line 54: <dependency> Line 55: <groupId>org.hibernate</groupId> Line 56: <artifactId>hibernate-entitymanager</artifactId> Line 57: <version>4.3.0.Final</version> we should put the version at root pom.xml Line 58: </dependency> Line 59: Line 60: <dependency> Line 61: <groupId>javax.annotation</groupId> Line 59: Line 60: <dependency> Line 61: <groupId>javax.annotation</groupId> Line 62: <artifactId>javax.annotation-api</artifactId> Line 63: <version>1.2</version> we should put the version at root pom.xml Line 64: </dependency> Line 65: </dependencies> Line 66: Line 67: <build> http://gerrit.ovirt.org/#/c/33832/15/backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml File backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml: Line 20: <module name="org.hibernate.validator"/> Line 21: <module name="org.ovirt.engine.core.compat"/> Line 22: <module name="org.slf4j"/> Line 23: <module name="javax.persistence.api"/> Line 24: <module name="org.hibernate"/> please sort() Line 25: </dependencies> Line 26: http://gerrit.ovirt.org/#/c/33832/15/backend/manager/modules/dal/pom.xml File backend/manager/modules/dal/pom.xml: Line 74: </dependency> Line 75: <dependency> Line 76: <groupId>org.hibernate</groupId> Line 77: <artifactId>hibernate-entitymanager</artifactId> Line 78: <version>4.0.1.Final</version> we should put the version at root pom.xml Line 79: </dependency> Line 80: </dependencies> Line 81: <build> Line 82: <filters> http://gerrit.ovirt.org/#/c/33832/15/backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml File backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml: Line 17: <module name="org.ovirt.engine.core.utils"/> Line 18: <module name="org.slf4j"/> Line 19: <module name="org.springframework"/> Line 20: <module name="org.hibernate"/> Line 21: <module name="javax.persistence.api"/> please sort Line 22: </dependencies> Line 23: http://gerrit.ovirt.org/#/c/33832/15/ear/pom.xml File ear/pom.xml: Line 235 Line 236 Line 237 Line 238 Line 239 remove from patch http://gerrit.ovirt.org/#/c/33832/15/ear/src/main/application/META-INF/jboss-deployment-structure.xml File ear/src/main/application/META-INF/jboss-deployment-structure.xml: Line 6: <module name="javax.inject.api"/> Line 7: <module name="javax.interceptor.api"/> Line 8: <module name="org.hibernate"/> Line 9: <module name="javax.persistence.api"/> Line 10: <module name="org.hibernate.envers"/> please sort() Line 11: <module name="org.ovirt.engine.core.common" export="true" meta-inf="import"/> Line 12: <module name="org.ovirt.engine.core.utils" export="true" meta-inf="import"/> Line 13: <module name="org.ovirt.engine.core.dal" export="true" meta-inf="import"/> Line 14: <module name="org.ovirt.engine.core.aaa" export="true" meta-inf="import"/> http://gerrit.ovirt.org/#/c/33832/15/pom.xml File pom.xml: Line 79: <findbugs.version>2.5.2</findbugs.version> Line 80: <mockito.version>1.9.0</mockito.version> Line 81: <javassist.version>3.12.0.GA</javassist.version> Line 82: <javax.mail.version>1.4.4</javax.mail.version> Line 83: <hibernate-validator.version>4.3.1.Final</hibernate-validator.version> jboss-7.1.1 has 4.2 Line 84: <jackson-core-asl.version>1.9.9</jackson-core-asl.version> Line 85: <jackson-mapper-asl.version>1.9.9</jackson-mapper-asl.version> Line 86: <commons-configuration.version>1.6</commons-configuration.version> Line 87: <commons-jxpath.version>1.3</commons-jxpath.version> -- To view, visit http://gerrit.ovirt.org/33832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2440162230449d0c335a2c2d418fb9ff7e854793 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
