Moti Asayag has posted comments on this change. Change subject: core: Add JPA infrastructure to oVirt ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/33832/13/backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml File backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml: Line 5: <property name="javax.persistence.jdbc.driver" value="${engine.db.driver}" /> Line 6: <property name="javax.persistence.jdbc.user" value="${engine.db.username}" /> Line 7: <property name="javax.persistence.jdbc.password" value="${engine.db.password}" /> Line 8: <property name="javax.persistence.jdbc.url" value="${engine.db.url}" /> Line 9: <property name="javax.persistence.validation.mode" value="NONE" /> Since we're already having a usage of the Hibernate validation, wouldn't we like to enhance it to db layer as well ? There are entities which are created internally (i.e. as result of host monitoring / vm monitoring / statistics collection) and to my best of knowledge - not all being validated before persisted to db. Line 10: <property name="hibernate.dialect" value="org.hibernate.dialect.HSQLDialect" /> Line 11: </properties> Line 12: </persistence-unit> Line 6: <property name="javax.persistence.jdbc.user" value="${engine.db.username}" /> Line 7: <property name="javax.persistence.jdbc.password" value="${engine.db.password}" /> Line 8: <property name="javax.persistence.jdbc.url" value="${engine.db.url}" /> Line 9: <property name="javax.persistence.validation.mode" value="NONE" /> Line 10: <property name="hibernate.dialect" value="org.hibernate.dialect.HSQLDialect" /> Why not org.hibernate.dialect.PostgreSQLDialect ? Line 11: </properties> Line 12: </persistence-unit> -- To view, visit http://gerrit.ovirt.org/33832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2440162230449d0c335a2c2d418fb9ff7e854793 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
