Amit Aviram has posted comments on this change. Change subject: webadmin: Correction of UI Constants ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34595/1//COMMIT_MSG Commit Message: Line 8: Line 9: Messages that was using the word "Detach" incorrectly, namely using Line 10: capital "D" when there was no need to- changed to "detach". Line 11: In addition, the "Data Center" part of the message who related Line 12: to detaching storage from a data center has changed back to > Maybe I am missing here something, but this patch doesn't touch any occurre You right, that's weird because the change is there... Don't know how that happend. Line 13: "Data Center(s)" due to the fact that it is possible that some Line 14: chosen Storage is attached to more than one Data Center. Line 15: Line 16: Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7 http://gerrit.ovirt.org/#/c/34595/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 785: Line 786: @DefaultStringValue("There are No Data Centers to which the Storage Domain can be attached") Line 787: String thereAreNoDataCenterStorageDomainAttachedMsg(); Line 788: Line 789: @DefaultStringValue("Are you sure you want to detach Storage from the following Data Center(s)?") > Why did you change "storage" to "Storage"? https://bugzilla.redhat.com/show_bug.cgi?id=1149457 the conclusion was to just change s->S Line 790: String areYouSureYouWantDetachStorageFromDcsMsg(); Line 791: Line 792: @DefaultStringValue("There is no Data Storage Domain to import the Template into. Please attach a Data Storage Domain to the Template's Data Center.") Line 793: String thereIsNoDataStorageDomainToImportTemplateIntoMsg(); -- To view, visit http://gerrit.ovirt.org/34595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
