Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34750/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 42: %if %{?_ovirt_build_extra_flags:1}%{?ovirt_build_extra_flags:1}0 Line 43: %global EXTRA_BUILD_FLAGS %{?_ovirt_build_extra_flags:%{_ovirt_build_extra_flags}}%{?ovirt_build_extra_flags: %{ovirt_build_extra_flags}} Line 44: %endif Line 45: Line 46: %if 0%{?fedora} || 0%{?rhel} >= 7 > I am almost sure that rhel's rpmbuild does not support complex conditions. well, it's not so complex. and at least it works for other projects like log collector, hosted engine and vdsm. But I'll verify the build on RHEL 6.6 too just to be sure. Line 47: %global ovirt_install_systemd 1 Line 48: %global ovirt_install_systemv 0 Line 49: %global ovirt_install_poms 1 Line 50: %global ovirt_require_maven 1 -- To view, visit http://gerrit.ovirt.org/34750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
