Alon Bar-Lev has posted comments on this change. Change subject: packaging: spec: add support for EL7 builds ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34750/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 42: %if %{?_ovirt_build_extra_flags:1}%{?ovirt_build_extra_flags:1}0 Line 43: %global EXTRA_BUILD_FLAGS %{?_ovirt_build_extra_flags:%{_ovirt_build_extra_flags}}%{?ovirt_build_extra_flags: %{ovirt_build_extra_flags}} Line 44: %endif Line 45: Line 46: %if 0%{?fedora} || 0%{?rhel} >= 7 I am almost sure that rhel's rpmbuild does not support complex conditions. you should use something like: %if 0${fedora} %global x = 1 %elif 0%{rhel} >= 7 %global x = 1 %else %global x = 0 %endif Line 47: %global ovirt_install_systemd 1 Line 48: %global ovirt_install_systemv 0 Line 49: %global ovirt_install_poms 1 Line 50: %global ovirt_require_maven 1 Line 183: Line 184: %if 0%{?rhel} == 6 Line 185: BuildRequires: java7-devel Line 186: %endif Line 187: %if 0%{?fedora} || 0%{?rhel} >= 7 this is the only one I am unsure about. Line 188: BuildRequires: java-devel >= 1.7.0 Line 189: %endif Line 190: Line 191: BuildRequires: jpackage-utils -- To view, visit http://gerrit.ovirt.org/34750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6fcef7e48cc1f616b09b4c3cb42b9bb92a8259f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
