Alexander Wels has posted comments on this change. Change subject: engine: don't read external files in unit test ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34678/3/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java: Line 37: @Before Line 38: public void setup() throws IOException, URISyntaxException { Line 39: canReadFileName = this.getClass().getResource("small_file.txt").toURI().toASCIIString().replaceAll("file:", ""); Line 40: System.setProperty("org.ovirt.engine.mime.types", Line 41: this.getClass().getResource("mime.types").toURI().toASCIIString().replaceAll("file:", "")); > won't it better to set this within pom.xml to effect all tests? There is only one tests that cares about the mime types, so currently it won't matter much either way. I am not expecting more unit tests to care about this file. Line 42: } Line 43: Line 44: /** Line 45: * Test method for {@link org.ovirt.engine.core.utils.servlet.ServletUtils#canReadFile(java.io.File)}. -- To view, visit http://gerrit.ovirt.org/34678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
