Alon Bar-Lev has posted comments on this change.
Change subject: engine: don't read external files in unit test
......................................................................
Patch Set 1:
(1 comment)
I think that:
new File (System.getProperty("org.ovirt.engine.mime.types", "/etc/mine.types"))
is simpler... and can reside in the operative code.
http://gerrit.ovirt.org/#/c/34678/1/backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/mime.types
File
backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/mime.types:
no need for the entire file into our repository, only what used by ut.
Line 1: # This is a comment. I love comments. -*-
indent-tabs-mode: t -*-
Line 2:
Line 3: # This file controls what Internet media types are sent to the client
for
Line 4: # given file extension(s). Sending the correct media type to the client
--
To view, visit http://gerrit.ovirt.org/34678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
