Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 25: (1 comment) http://gerrit.ovirt.org/#/c/33458/25/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 54: public List<? extends Certificate> getCertificateChain() { Line 55: List<? extends Certificate> result = null; Line 56: if (url.getProtocol().equalsIgnoreCase(String.valueOf("https"))) { Line 57: try { Line 58: result = CertificateChain.getSSLPeerCertificates(url); even me forgot what I wrote in this class :) proper usage: certs = completeChain( CertificateChain.getSSLPeerCertificates(url), CertificateChain.keyStoreToTrustAnchors(YOUR OWN KEYSTORE) // can be null if no external exists so far ); Line 59: } catch (IOException | GeneralSecurityException e) { Line 60: handleException(e); Line 61: } Line 62: } -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
