Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 25: (2 comments) http://gerrit.ovirt.org/#/c/33458/25/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 205: # Line 206: # PKI artifacts Line 207: # Line 208: SENSITIVE_KEYS="${SENSITIVE_KEYS},ENGINE_PKI_TRUST_STORE_PASSWORD,ENGINE_PKI_ENGINE_STORE_PASSWORD" Line 209: ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE="${ENGINE_VAR}/external_truststore" better to have the type and password as the rest. Line 210: ENGINE_PKI_CA=${ENGINE_PKI}/ca.pem Line 211: ENGINE_PKI_ENGINE_CERT=${ENGINE_PKI}/certs/engine.cer Line 212: ENGINE_PKI_TRUST_STORE_TYPE=JKS Line 213: ENGINE_PKI_TRUST_STORE=${ENGINE_PKI}/.truststore Line 216: ENGINE_PKI_ENGINE_STORE=${ENGINE_PKI}/keys/engine.p12 Line 217: ENGINE_PKI_ENGINE_STORE_PASSWORD= Line 218: ENGINE_PKI_ENGINE_STORE_ALIAS=1 Line 219: Line 220: not part of this patch. Line 221: # Line 222: # Reports Line 223: # by default serv 404. Line 224: # -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
