Shirly Radco has posted comments on this change.

Change subject: packaging: setup: Stop remote dwh
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34566/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py:

Line 81: 
Line 82:     @plugin.event(
Line 83:         stage=plugin.Stages.STAGE_MISC,
Line 84:         before=(
Line 85:             oengcommcons.Stages.DB_SCHEMA,
Yaniv, is this early enough? Do we have other things in engine setup (upgrade) 
that might interfere with a remote dwh?
Line 86:         ),
Line 87:         condition=lambda self: (
Line 88:             self.environment[oenginecons.CoreEnv.ENABLE] and
Line 89:             not self.environment[oenginecons.EngineDBEnv.NEW_DATABASE]


-- 
To view, visit http://gerrit.ovirt.org/34566
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to