Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Stop remote dwh ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34566/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py: Line 63: 'name': 'DisconnectDwh', Line 64: 'value': value, Line 65: }, Line 66: ), Line 67: ownConnection=True, This is needed, but should be harmless. we just turn if on and off. If we fail in the middle, it's just left 'on', meaning asking a remote dwh to stop, which we probably want to, until the engine upgrade is retried/fixed. Line 68: ) Line 69: Line 70: @plugin.event( Line 71: stage=plugin.Stages.STAGE_INIT, Line 75: Line 76: @plugin.event( Line 77: stage=plugin.Stages.STAGE_MISC, Line 78: before=( Line 79: oengcommcons.Stages.DB_SCHEMA, That's where we update the engine db. Do we want anything else? Line 80: ), Line 81: condition=lambda self: ( Line 82: self.environment[oenginecons.CoreEnv.ENABLE] and Line 83: not self.environment[oenginecons.EngineDBEnv.NEW_DATABASE] -- To view, visit http://gerrit.ovirt.org/34566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
