Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Entities for gluster volume snapshot ......................................................................
Patch Set 6: (5 comments) http://gerrit.ovirt.org/#/c/23199/6/packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql File packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql: Line 5: -- Add gluster_volume_snapshots table Line 6: CREATE TABLE gluster_volume_snapshots Line 7: ( Line 8: snapshot_id UUID NOT NULL, Line 9: cluster_id UUID NOT NULL, > cluster_id or volume_id? below entity_id is actually volume_id. Named as entity_id as later we might utilize same field for consistency group as well. Line 10: entity_id UUID NOT NULL, Line 11: snapshot_name VARCHAR(1000) NOT NULL, Line 12: created_at TIMESTAMP WITH TIME ZONE, Line 13: description VARCHAR(1024), Line 6: CREATE TABLE gluster_volume_snapshots Line 7: ( Line 8: snapshot_id UUID NOT NULL, Line 9: cluster_id UUID NOT NULL, Line 10: entity_id UUID NOT NULL, > or is entity_id refering to volume_id in case of volume_snapshot? above comments Line 11: snapshot_name VARCHAR(1000) NOT NULL, Line 12: created_at TIMESTAMP WITH TIME ZONE, Line 13: description VARCHAR(1024), Line 14: status VARCHAR(32), Line 15: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 16: _update_date TIMESTAMP WITH TIME ZONE, Line 17: CONSTRAINT pk_gluster_volume_snapshots PRIMARY KEY(snapshot_id, cluster_id, entity_id) Line 18: ) WITH OIDS; Line 19: CREATE UNIQUE INDEX IDX_gluster_volume_snapshots_unique ON gluster_volume_snapshots(snapshot_id, cluster_id, entity_id); > Is this required? PK would create a unique index. Yes. would remove one of them. Line 20: Line 21: -- Add gluster_volume_snapshot_config table Line 22: CREATE TABLE gluster_volume_snapshot_config Line 23: ( Line 25: entity_id UUID NOT NULL, Line 26: param_name VARCHAR(128) NOT NULL, Line 27: param_value VARCHAR(128) Line 28: ) WITH OIDS; Line 29: CREATE UNIQUE INDEX IDX_gluster_volume_snapshot_config_unique ON gluster_volume_snapshot_config(cluster_id, entity_id); > Shouldn't this have param_name as well as part of index? Yes. Thanks for identifying. Would add. Line 30: Line 31: END; $function$ Line 32: LANGUAGE plpgsql; Line 33: http://gerrit.ovirt.org/#/c/23199/6/packaging/dbscripts/upgrade/03_06_0490_add_snapshot_enabled_flag_to_gluster_volumes.sql File packaging/dbscripts/upgrade/03_06_0490_add_snapshot_enabled_flag_to_gluster_volumes.sql: Line 1: SELECT fn_db_add_column('gluster_volumes', 'snapshot_enabled_flag', 'char'); > Why is this required? When would this flag be set? As discussed I would remove this. -- To view, visit http://gerrit.ovirt.org/23199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
