Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Entities for gluster volume snapshot ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/23199/8/packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql File packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql: Line 1: Create or replace FUNCTION __temp_fn_db_add_gluster_volume_snapshot_tables() > I don't think you need functions anymore...see http://gerrit.ovirt.org/#/c/ Will change accordingly Line 2: RETURNS void Line 3: AS $function$ Line 4: BEGIN Line 5: -- Add gluster_volume_snapshots table Line 6: CREATE TABLE gluster_volume_snapshots Line 7: ( Line 8: snapshot_id UUID NOT NULL, Line 9: cluster_id UUID NOT NULL, Line 10: entity_id UUID NOT NULL, > How would you know if this was volumeId or ConsistenceGroupId? I remember it was always one way from CG/Volume to snapshot, so either CG id or volume id would be populated as entity_id here and we can query based on cluster_id + entity_id whenever needed. Still do you feel a clear segregation required? I am not sure. Line 11: snapshot_name VARCHAR(1000) NOT NULL, Line 12: created_at TIMESTAMP WITH TIME ZONE, Line 13: description VARCHAR(1024), Line 14: status VARCHAR(32), -- To view, visit http://gerrit.ovirt.org/23199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Nishanth Thomas <nishusem...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
