Roy Golan has posted comments on this change.

Change subject: core: Preventing two Network Interfaces with same IP (#839199)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java
Line 20:                 if (staticIps.contains(networkInterface.getAddress())) 
{
if for some reason, god knows why the address is null or empty your in trouble. 
check with StringUtils.isEmpty

--
To view, visit http://gerrit.ovirt.org/6695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to