Sahina Bose has posted comments on this change. Change subject: webadmin : Add Geo-Replication Sub-tab under Volumes MainTab ......................................................................
Patch Set 29: (1 comment) http://gerrit.ovirt.org/#/c/29628/29/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 191: // dictionary to hold cache of all config values (per version) queried by client, if the request for them succeeded. Line 192: private final HashMap<KeyValuePairCompat<ConfigurationValues, String>, Object> cachedConfigValues = Line 193: new HashMap<KeyValuePairCompat<ConfigurationValues, String>, Object>(); Line 194: Line 195: private final HashMap<KeyValuePairCompat<ConfigurationValues, String>, Object> cachedConfigValuesPreConvert = > why this change required? aah..that's my eclipse auto-save setting :( Line 196: new HashMap<KeyValuePairCompat<ConfigurationValues, String>, Object>(); Line 197: Line 198: private String _defaultConfigurationVersion = null; Line 199: -- To view, visit http://gerrit.ovirt.org/29628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbcd5e0218d93c1d198462133b2efc883267ffa Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
