Sahina Bose has posted comments on this change. Change subject: webadmin : Add Geo-Replication Sub-tab under Volumes MainTab ......................................................................
Patch Set 28: (5 comments) http://gerrit.ovirt.org/#/c/29628/28/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 1547: }; Line 1548: Frontend.getInstance().runQuery(VdcQueryType.GetGlusterVolumeBricksByServerId, new IdQueryParameters(serverId), aQuery); Line 1549: } Line 1550: Line 1551: public void getGlusterVolumeGeoRepStatusForMasterVolume(AsyncQuery aQuery, Guid masterVolumeId, Guid masterVolumeClusterId) { > masterVolumeClusterId is not being used? No..it's not after the refactoring of query. will refactor this method as well. Line 1552: aQuery.converterCallback = new IAsyncConverter() { Line 1553: @Override Line 1554: public Object Convert(Object source, AsyncQuery asyncQuery) { Line 1555: return source != null ? source : new ArrayList<GlusterGeoRepSession>(); http://gerrit.ovirt.org/#/c/29628/28/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 129: AsyncDataProvider.getInstance().getGlusterVolumeGeoRepStatusForMasterVolume(new AsyncQuery(this, new INewAsyncCallback() { Line 130: @Override Line 131: public void onSuccess(Object model, Object returnValue) { Line 132: List<GlusterGeoRepSession> geoRepSessions = (ArrayList<GlusterGeoRepSession>) returnValue; Line 133: if(getItems() == geoRepSessions) { > When will this be equal '==' ? changing this. Line 134: getItemsChangedEvent().raise(this, EventArgs.EMPTY); Line 135: } else { Line 136: Collections.sort(geoRepSessions, new Linq.GlusterVolumeGeoRepSessionComparer()); Line 137: setItems(geoRepSessions); Line 142: setItems(null); Line 143: } Line 144: } Line 145: Line 146: private void updateActionAvailability(GlusterVolumeEntity volumeEntity) { > I would suggest to keep all the actions disabled till the respective featur Done Line 147: if(volumeEntity == null) { Line 148: return; Line 149: } Line 150: boolean isNewSessionAvailable = true; http://gerrit.ovirt.org/#/c/29628/28/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java: Line 305: public static final String volumePermissionSubTabPlace = volumeMainTabPlace + SUB_TAB_PREFIX + "permissions"; //$NON-NLS-1$ Line 306: Line 307: public static final String volumeEventSubTabPlace = volumeMainTabPlace + SUB_TAB_PREFIX + "events"; //$NON-NLS-1$ Line 308: Line 309: public static final String volumeGeoRepSubTabPlace = volumeMainTabPlace + SUB_TAB_PREFIX + "geo-rep"; //$NON-NLS-1$ > this should be "geo_rep" Done Line 310: Line 311: // Disk Line 312: Line 313: public static final String diskGeneralSubTabPlace = diskMainTabPlace + SUB_TAB_PREFIX + "general"; //$NON-NLS-1$ http://gerrit.ovirt.org/#/c/29628/28/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java: Line 38: ViewIdHandler.idHandler.generateAndSetIds(this); Line 39: } Line 40: Line 41: void initTable(ApplicationConstants constants) { Line 42: getTable().enableColumnResizing(); > explicit width needs to set for the columns in case resize is required Done Line 43: getTable().addColumn(new TextColumnWithTooltip<GlusterGeoRepSession>() { Line 44: @Override Line 45: public String getValue(GlusterGeoRepSession object) { Line 46: return object.getSlaveHostName(); -- To view, visit http://gerrit.ovirt.org/29628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbcd5e0218d93c1d198462133b2efc883267ffa Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
