Alon Bar-Lev has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll ......................................................................
Patch Set 4: (42 comments) please also remove reference from: backend/manager/modules/utils/exclude-filters.xml http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 74: vmTemplateFromConfiguration.setDiskList(imageList); Line 75: ensureDomainMap(imageList, getParameters().getDestDomainId()); Line 76: } Line 77: } catch (OvfReaderException e) { Line 78: log.error("failed to parse a given ovf configuration: \n{}", ovfEntityData.getOvfData()); space before \n Line 79: log.error("Exception", e); Line 80: } Line 81: } Line 82: setVdsGroupId(getParameters().getVdsGroupId()); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 545 Line 546 Line 547 Line 548 Line 549 stack? Line 266: + " status - not failing the operation", Line 267: vds.getName(), Line 268: storagePool.getName()); Line 269: } else { Line 270: log.error("Could not connect host '{}' to pool '{}' with the message: {}", s/ with the message// Line 271: vds.getName(), Line 272: storagePool.getName(), Line 273: error.getMessage()); Line 274: result.setSuccess(false); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java: Line 78: error = true; Line 79: log.error( Line 80: "Installation of Host. Received illegal XML from Host. Message: {}", Line 81: message); Line 82: log.error("Exception", e); can be debug Line 83: } Line 84: } else { Line 85: log.info("VDS message: {}", message); Line 86: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java: Line 484 Line 485 Line 486 Line 487 Line 488 tostring http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java: Line 241: throw e; Line 242: } Line 243: catch (Exception e) { Line 244: log.error("Error during node '{}' upgrade: {}", _vds.getHostName(), e.getMessage()); Line 245: log.debug("Exception", e); this should be error until we remove this class. Line 246: Line 247: if (_failException == null) { Line 248: throw e; Line 249: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java: Line 76 Line 77 Line 78 Line 79 Line 80 s/, Error// http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java: Line 215: Line 216: if (retValue.getSucceeded()) { Line 217: removeInProcessImageIds.add(diskImage.getImageId()); Line 218: } else { Line 219: log.error("Failed to remove image <{}>", diskImage.getImageId()); '{}' ? Line 220: } Line 221: } Line 222: } Line 223: http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java: Line 99: log.error("SSH Soft Fencing command failed on host '{}': {}\nStdout: {}\nStderr: {}", Line 100: getVds().getHostName(), Line 101: ex.getMessage(), Line 102: cmdOut.toString(), Line 103: cmdErr.toString()); toString Line 104: log.debug("Exception", ex); Line 105: } Line 106: } Line 107: catch(IOException e) { http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java: Line 176: if (!canDoActionMessages.isEmpty()) { Line 177: // add can do action messages to return value so error messages Line 178: // are returned back to the client Line 179: getReturnValue().getCanDoActionMessages().addAll(canDoActionMessages); Line 180: log.error("Installation/upgrade of Host '{}', '{}' failed due to: {} ", s/ due to// Line 181: getVdsId(), Line 182: getVdsName(), Line 183: StringUtils.join(Backend.getInstance() Line 184: .getErrorsTranslator() http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java: Line 255 Line 256 Line 257 Line 258 Line 259 stack? Line 251: dstFld.setAccessible(true); Line 252: dstFld.set(dest, srcFld.get(source)); Line 253: } Line 254: } catch (Exception exp) { Line 255: log.error("Failed to copy field '{}' of new version to VM '{}' ({}), error: {}", s/, error// Line 256: srcFld.getName(), Line 257: source.getName(), Line 258: source.getId(), Line 259: exp.getMessage()); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java: Line 80 Line 81 Line 82 Line 83 Line 84 stack? Line 77: } Line 78: } Line 79: } catch (IOException e) { Line 80: log.error( Line 81: "Cannot get canonical path to '{}' with error {}", s/ with error/:/ Line 82: iso.getName(), Line 83: ExceptionUtils.getMessage(e) Line 84: ); Line 85: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 302: new ArrayList<>(createMigrateVmToServerParametersList(vmsToMigrate, vds)), Line 303: ctx); Line 304: } Line 305: } catch (RuntimeException e) { Line 306: log.error("Failed to initialize Vds on up.", e); intentional at error? Line 307: } Line 308: } Line 309: }); Line 310: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java: Line 82 Line 83 Line 84 Line 85 Line 86 stack? Line 78: static public RpmVersion getOvirtHostOsVersion(VDS vds) { Line 79: try { Line 80: return new RpmVersion(vds.getHostOs(), "RHEV Hypervisor -", true); Line 81: } catch (RuntimeException e) { Line 82: log.error("Failed to parse version of Host '{}','{}' and Host OS '{}' with error {}", s/ with error/:/ Line 83: vds.getId(), Line 84: vds.getName(), Line 85: vds.getHostOs(), Line 86: ExceptionUtils.getMessage(e)); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java: Line 38 Line 39 Line 40 Line 41 Line 42 - Line 44 Line 45 Line 46 Line 47 Line 48 - Line 112: log.error("SSH power down command failed on host '{}': {}\nStdout: {}\nStderr: {}", Line 113: getVds().getHostName(), Line 114: ex.getMessage(), Line 115: cmdOut.toString(), Line 116: cmdErr.toString()); toString Line 117: log.debug("Exception", ex); Line 118: } Line 119: } Line 120: catch(IOException e) { http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 410 Line 411 Line 412 Line 413 Line 414 getMessage? stack? http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java: Line 108: entity.getStage(), Line 109: entity.getName())); Line 110: if (!retValue.getSucceeded()) { Line 111: // throw exception as we cannot continue without content Line 112: log.error("Failed to get content from server with id '{}' with error: {}", getParameters().getSourceServerId(), retValue.getExceptionString()); s/ with error// Line 113: throw new VdcBLLException(retValue.getVdsError().getCode(), retValue.getVdsError().getMessage()); Line 114: } Line 115: hookContent = (String) retValue.getReturnValue(); Line 116: hookChecksum = sourceServerHook.getChecksum(); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 54 Line 55 Line 56 Line 57 Line 58 stack? Line 53: try { Line 54: returnValue = runVdsCommand(VDSCommandType.GetVGInfo, Line 55: new GetVGInfoVDSCommandParameters(getParameters().getVdsId(), vgId)); Line 56: } catch (RuntimeException e) { Line 57: log.error("Could not get info for VG ID '{}'. Error message: {}", s/. Error message// Line 58: vgId, e.getMessage()); Line 59: return luns; Line 60: } Line 61: http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java: Line 198: }); Line 199: if (CollectionUtils.subtract(strings, failedConnectionsList).size() == 0) { Line 200: // At case of failure the appropriate log message will be Line 201: // added Line 202: log.info("The lun with id '{}' was reported as problematic !", lun.getphysical_volume_id()); s/ !// Line 203: for (String connectionFailed : failedConnectionsList) { Line 204: String connectionField = Line 205: addToAuditLogErrorMessage(connectionFailed, Line 206: returnValue.get(connectionFailed), http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 270 Line 271 Line 272 Line 273 Line 274 s/. error/:/ Line 271 Line 272 Line 273 Line 274 Line 275 stack? http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperation.java: Line 47: VDSCommandType.ConnectStoragePool, Line 48: new ConnectStoragePoolVDSCommandParameters(getVdss().get(iterationId), Line 49: getStoragePool(), masterStorageDomainId, storagePoolIsoMap)); Line 50: } catch (Exception e) { Line 51: log.error("Could not connect vds '{}' to pool '{}' - moving host to non-operational. Error: {}", s/. Error// Line 52: getVdss().get(iterationId).getName(), Line 53: getStoragePool().getName(), Line 54: e.getMessage()); Line 55: log.debug("Exception", e); Line 66: getStoragePool().getName()); Line 67: } Line 68: Line 69: } catch (RuntimeException e) { Line 70: log.error("Failed to connect/refresh storagePool. Host '{}' to storage pool '{}'. Error: {}", s/. Error// Line 71: getVdss().get(iterationId).getName(), Line 72: getStoragePool().getName(), Line 73: e.getMessage()); Line 74: log.debug("Exception", e); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java: Line 40: masterStorageDomainId, storagePoolIsoMap, true)); Line 41: StorageHelperDirector.getInstance().getItem(getStorageDomain().getStorageType()) Line 42: .disconnectStorageFromDomainByVdsId(getStorageDomain(), getVdss().get(iterationId).getId()); Line 43: } catch (RuntimeException e) { Line 44: log.error("Failed to connect/refresh storagePool. Host '{}' to storage pool '{}'. Error: {}", s/. Error// Line 45: getVdss().get(iterationId).getName(), Line 46: getStoragePool().getName(), Line 47: e.getMessage()); Line 48: log.debug("Exception", e); http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 240: return null; Line 241: } Line 242: }); Line 243: } catch (Exception e1) { Line 244: log.error("Failed destroy storage pool with id '{}' and after that failed to stop spm because of {}", s/ because of/:/ Line 245: getStoragePoolId(), Line 246: e1.getMessage()); Line 247: log.debug("Exception", e1); Line 248: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java: Line 510 Line 511 Line 512 Line 513 Line 514 stack? Line 712 Line 713 Line 714 Line 715 Line 716 stack? Line 711: } Line 712: addTaskToManager(task); Line 713: newlyAddedTasks.add(task); Line 714: } catch (Exception e) { Line 715: log.error("Failed to load task of type '{}' with id '{}', due to: {}.", s/, due to// Line 716: creationInfo.getTaskType(), creationInfo.getVdsmTaskId(), Line 717: ExceptionUtils.getRootCauseMessage(e)); Line 718: } Line 719: } http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java: Line 148 Line 149 Line 150 Line 151 Line 152 log.error("{}: {}", getErrorMessage(), ex.getMessage()); Line 231: } Line 232: Line 233: else { Line 234: log.info("CommandAsyncTask::HandleEndActionResult [within thread]: endAction for action type" Line 235: + " '{}' {}succeeded, clearing tasks.", space before succeeded? Line 236: actionType, Line 237: vdcReturnValue.getSucceeded() ? "" : "hasn't "); Line 238: Line 239: /** http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java: Line 389: getParameters().getClass().getName()); Line 390: Line 391: coco.stopTask(getStoragePoolID(), getVdsmTaskId()); Line 392: } catch (RuntimeException e) { Line 393: log.error("SPMAsyncTask::StopTask: Stopping task '{}' threw an exception: {}", Error during... remove threw an excpetion Line 394: getVdsmTaskId(), Line 395: e.getMessage()); Line 396: log.debug("Exception", e); Line 397: } finally { Line 426: } Line 427: Line 428: catch (RuntimeException e) { Line 429: log.error("SPMAsyncTask::ClearAsyncTask: Clearing task '{}' threw an exception: {}", Line 430: getVdsmTaskId(), Error during... remove threw an excpetion Line 431: e.getMessage()); Line 432: log.error("Exception", e); Line 433: } Line 434: http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java: Line 141: client.authenticate(); Line 142: } catch (AuthenticationException e) { Line 143: throw e; Line 144: } catch (Exception e) { Line 145: log.error("Exception during authentication: {}", e.getMessage()); stack? Line 146: throw new RuntimeException(e); Line 147: } Line 148: } Line 149: Line 156: } catch (Exception e) { Line 157: log.error("Error while executing command '{}' on server '{}': {}", Line 158: command, Line 159: client.getHost(), Line 160: e.getMessage()); stack? Line 161: throw new RuntimeException(e); Line 162: } Line 163: } Line 164: Line 202: Line 203: try { Line 204: return getServers(XmlUtils.loadXmlDoc(serversXml).getElementsByTagName(PEER)); Line 205: } catch (Exception e) { Line 206: log.error("Error while parsing peer list xml [{}]: {}", serversXml, e.getMessage()); stack? Line 207: throw new RuntimeException(e); Line 208: } Line 209: } Line 210: http://gerrit.ovirt.org/#/c/34359/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java: Line 48: if (isVersionSupported) { Line 49: try { Line 50: isVersionSupported = vds.getSupportedClusterVersionsSet().contains(clusterCompatibilityVersion); Line 51: } catch (RuntimeException e) { Line 52: log.error(e.getMessage()); "{}", e.getMessage() stack? Line 53: isVersionSupported = false; Line 54: } Line 55: } Line 56: return isVersionSupported; -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
