Martin Sivák has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll/scheduling ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34359/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java: Line 179: client.execute(BALANCE, createBalanceArgs(balanceName, hostIDs, propertiesMap)); Line 180: return ExternalSchedulerBrokerObjectBuilder.getBalanceResults(result).getResult(); Line 181: Line 182: } catch (XmlRpcException e) { Line 183: log.error("Error communicate with the external scheduler while balancing: {}", e.getMessage()); Either Could not communicate or Error communicating Line 184: log.debug("Exception", e); Line 185: auditLogFailedToConnect(); Line 186: return null; Line 187: } http://gerrit.ovirt.org/#/c/34359/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java: Line 63 Line 64 Line 65 Line 66 Line 67 Since you are cleaning up the messages.. could you please change "why" to "while" here? -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
