Doron Fediuck has posted comments on this change. Change subject: bootstrap: new implementation for apache-sshd usage ......................................................................
Patch Set 6: (2 inline comments) Alon- Thanks for cleaning up some of my mess.... Some minor renames I mentioned. There were others by I try to hold myself... Some words of caution: (1) Please make sure all your references to time both to external classes as well as internal one are in the same units. I had a very ugly rare bug there we accidentally stumbled upon. I tried looking for it in your implementation and didn't find it. Try to take another look if you can. (2) This area of the engine showed lots of CPU demands, and went through several cycles of performance tests, to see how the system behaves when running a script to install / register 100+ hosts. See if you can ask pre-integration or someone else to run similar tests on your patches. I think the new run command is less understandable (at least to me), comparing to the simple loop we had in run-ssh-command. So any future clarification would be appreciated. That said I like what you did and hope it'll perform better than my implementation. Kudos on the tests!!! Juan & Yair, Please review & add a note if there's something left you require to be fixed/changed. I'll re-check in a couple of days and approve if no comment added, and we have some sort of assurance on perf' status. .................................................... File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java Line 65: String _user_password; => _userPassword Line 66: PublicKey _user_key; => _userKey -- To view, visit http://gerrit.ovirt.org/6722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ba60f2db364114907485da3074feb714615e0c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
