Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: new implementation for apache-sshd usage ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/OvirtSSH.java Line 514: _validateDigest(localDigest, new String(remoteDigest.toByteArray(), "UTF-8").trim()); I disagree about the digest concurrency, as I get a digest anyway even if class is not thread safe, there is no problem in doing so, a digest will be returned. The Executors does not solve the problem as there is a need of inner thread anyway to pipe the data. But I will add the code to wait for the thread, it may case false negatives but OK. -- To view, visit http://gerrit.ovirt.org/6722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ba60f2db364114907485da3074feb714615e0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
