Piotr Kliczewski has posted comments on this change. Change subject: core: configurable ssl protocol ......................................................................
Patch Set 2: Verified+1 (1 comment) Verified using TLSv1 with vdsm configure with sslv3 and tlsv1 using xml and jsonrpc. http://gerrit.ovirt.org/#/c/34372/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java: Line 208: */ Line 209: public AuthSSLProtocolSocketFactory(KeyStore truststore) { Line 210: super(); Line 211: try { Line 212: this.protocol = "SSLv3"; We want to keep other providers as they were. We only make protocol configurable for xmlrpc. Line 213: TrustManagerFactory tmfactory = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); Line 214: tmfactory.init(truststore); Line 215: this.sslcontext = createSSLContext(null, tmfactory.getTrustManagers()); Line 216: } -- To view, visit http://gerrit.ovirt.org/34372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
