Piotr Kliczewski has posted comments on this change. Change subject: core: configurable ssl protocol ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34372/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 374: @TypeConverterAttribute(Boolean.class) Line 375: @DefaultValueAttribute("true") Line 376: EncryptHostCommunication, Line 377: @TypeConverterAttribute(String.class) Line 378: @DefaultValueAttribute("TLS") > it is an alias, please use TLSv1. Correct will update to TLSv1. Line 379: SSLProtocol, Line 380: @Reloadable Line 381: @TypeConverterAttribute(String.class) Line 382: @DefaultValueAttribute("oVirt") http://gerrit.ovirt.org/#/c/34372/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 632: select fn_db_add_config_value('DelayResetForSpmInSeconds','20','general'); Line 633: select fn_db_add_config_value('DelayResetPerVmInSeconds','0.5','general'); Line 634: --Handling Use Secure Connection with Hosts Line 635: select fn_db_add_config_value('EncryptHostCommunication','true','general'); Line 636: select fn_db_add_config_value('SSLProtocol','TLS','general'); > we need to enable engine-config integration. You are right I will update engine-config as well. Line 637: select fn_db_add_config_value('TimeToReduceFailedRunOnVdsInMinutes','30','general'); Line 638: select fn_db_add_config_value('UnknownTaskPrePollingLapse','60000','general'); Line 639: select fn_db_add_config_value('UserSessionHardLimit','600','general'); Line 640: select fn_db_add_config_value('UserDefinedVMProperties','','3.0'); -- To view, visit http://gerrit.ovirt.org/34372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
