Tomas Jelinek has posted comments on this change.

Change subject: webadmin: Fixed VM moving between clusters error.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34157/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java:

Line 30: import org.ovirt.engine.ui.uicommonweb.models.SystemTreeItemModel;
Line 31: import 
org.ovirt.engine.ui.uicommonweb.models.vms.instancetypes.ExistingVmInstanceTypeManager;
Line 32: import 
org.ovirt.engine.ui.uicommonweb.models.vms.instancetypes.InstanceTypeManager;
Line 33: 
Line 34: public class ExistingVmModelBehavior extends VmModelBehaviorBase {
> can you please extract the formatting to a separate patch, it's pretty hard
agree, please remove this formatting changes - I can't find the real changes...
Line 35:         private InstanceTypeManager instanceTypeManager;
Line 36: 
Line 37:         protected VM vm;
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/34157
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I191425b7d6ac53d0f6f9c3d5a3ba53d52e7e8c42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to