Daniel Erez has posted comments on this change. Change subject: webadmin: Fixed VM moving between clusters error. ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/34157/1//COMMIT_MSG Commit Message: Line 11: ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER Line 12: Line 13: But, after closing the message the vm would move to the other cluster Line 14: as meant. This bug was fixed and now no error message appears. Line 15: I think it would be clearer to separate these issues to different patches: 1. add message constants 2. fix described bug Line 16: Change-Id: I191425b7d6ac53d0f6f9c3d5a3ba53d52e7e8c42 Line 17: Bug-Url: https://bugzilla.redhat.com/1142629 http://gerrit.ovirt.org/#/c/34157/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 1041: ACTION_TYPE_DISK_PROFILE_EMPTY(ErrorType.BAD_PARAMETERS), Line 1042: ACTION_TYPE_FAILED_DISK_PROFILE_NOT_FOUND(ErrorType.BAD_PARAMETERS), Line 1043: ACTION_TYPE_DISK_PROFILE_STORAGE_DOMAIN_NOT_PROVIDED(ErrorType.BAD_PARAMETERS), Line 1044: ACTION_TYPE_DISK_PROFILE_NOT_MATCH_STORAGE_DOMAIN(ErrorType.BAD_PARAMETERS), Line 1045: ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER(ErrorType.BAD_PARAMETERS), is it relevant to this patch? formatting should usually be extract to a consecutive patches. Line 1046: ACTION_TYPE_CPU_PROFILE_CLUSTER_NOT_PROVIDED(ErrorType.BAD_PARAMETERS), Line 1047: ACTION_TYPE_CPU_PROFILE_EMPTY(ErrorType.BAD_PARAMETERS), Line 1048: ACTION_TYPE_FAILED_CPU_PROFILE_NOT_FOUND(ErrorType.BAD_PARAMETERS), Line 1049: ACTION_TYPE_CANNOT_REMOVE_LAST_CPU_PROFILE_IN_CLUSTER(ErrorType.NOT_SUPPORTED), http://gerrit.ovirt.org/#/c/34157/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 30: import org.ovirt.engine.ui.uicommonweb.models.SystemTreeItemModel; Line 31: import org.ovirt.engine.ui.uicommonweb.models.vms.instancetypes.ExistingVmInstanceTypeManager; Line 32: import org.ovirt.engine.ui.uicommonweb.models.vms.instancetypes.InstanceTypeManager; Line 33: Line 34: public class ExistingVmModelBehavior extends VmModelBehaviorBase { can you please extract the formatting to a separate patch, it's pretty hard to trace the changes... Line 35: private InstanceTypeManager instanceTypeManager; Line 36: Line 37: protected VM vm; Line 38: -- To view, visit http://gerrit.ovirt.org/34157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I191425b7d6ac53d0f6f9c3d5a3ba53d52e7e8c42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
