Yaniv Bronhaim has posted comments on this change. Change subject: restapi: Foreman host provider ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/33969/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-09 16:19:08 +0200 Line 4: Commit: Juan Hernandez <juan.hernan...@redhat.com> Line 5: CommitDate: 2014-10-16 13:10:54 +0200 Line 6: Line 7: restapi: Foreman host provider > I don't think so. Why would we need that? Doesn't the integration work with and also with standalone satellite.. will we modify it between rhev to ovirt? better just to call it host providers Line 8: Line 9: This patch adds the resources for the Foreman host providers. The Line 10: representation of the resource will look like this: Line 11: Line 5: CommitDate: 2014-10-16 13:10:54 +0200 Line 6: Line 7: restapi: Foreman host provider Line 8: Line 9: This patch adds the resources for the Foreman host providers. The > As far I can tell the backend modelling implementation of this is completel only share my opinion. because now i work with katello, that doesn't mention the name foreman anywhere, and i think it will confuse customers that knows only the downstream name Line 10: representation of the resource will look like this: Line 11: Line 12: GET /foremanhostproviders Line 13: <foreman_host_providers> Line 31: <property> Line 32: <name>prop2</name> Line 33: <value>value2</myvalue> Line 34: </property> Line 35: </properties> > It is there in the backend, if it isn't used by the Foreman integration I w we don't.. imo you can remove it Line 36: </foreman_host_provider> Line 37: Line 38: The providers collection will support listing, getting, adding, and Line 39: removing providers, with the usual methods. Line 97: <mac>52:54:00:1a:65:40</mac> Line 98: <subnet_name>...</subnet_name> Line 99: <last_report>...</last_report> Line 100: </foreman_discovered_host> Line 101: > Yes. It is unfortunate that this is implemented as "AddVds" in the backend. yes.. which should call to addHostCommand with privateAddProvisioned=true Line 102: For host groups: Line 103: Line 104: GET /foremanhostproviders/{provider:id}/hostgroups Line 105: <foreman_host_groups> -- To view, visit http://gerrit.ovirt.org/33969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2144125f00822263dc68da881eb3180c4cd6b237 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
