Yaniv Bronhaim has posted comments on this change. Change subject: restapi: Foreman host provider ......................................................................
Patch Set 6: (5 comments) http://gerrit.ovirt.org/#/c/33969/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-09 16:19:08 +0200 Line 4: Commit: Juan Hernandez <juan.hernan...@redhat.com> Line 5: CommitDate: 2014-10-16 13:10:54 +0200 Line 6: Line 7: restapi: Foreman host provider do we need to mention "satellite" somewhere? Line 8: Line 9: This patch adds the resources for the Foreman host providers. The Line 10: representation of the resource will look like this: Line 11: Line 5: CommitDate: 2014-10-16 13:10:54 +0200 Line 6: Line 7: restapi: Foreman host provider Line 8: Line 9: This patch adds the resources for the Foreman host providers. The not specifically foreman.. I'd remove the "foreman" from all those verbs. just host_providers Line 10: representation of the resource will look like this: Line 11: Line 12: GET /foremanhostproviders Line 13: <foreman_host_providers> Line 31: <property> Line 32: <name>prop2</name> Line 33: <value>value2</myvalue> Line 34: </property> Line 35: </properties> I'm not familiar with such option to add properties to the providers.. Line 36: </foreman_host_provider> Line 37: Line 38: The providers collection will support listing, getting, adding, and Line 39: removing providers, with the usual methods. Line 41: provider resource will support getting, deleting and updating the provider, : with the usual methods. same sentence twice.. or collection and resource are two different things Line 97: <mac>52:54:00:1a:65:40</mac> Line 98: <subnet_name>...</subnet_name> Line 99: <last_report>...</last_report> Line 100: </foreman_discovered_host> Line 101: ^ don't we need to have an api to add the discovered\provisioned hosts (which means, provision it by foreman). basically its the same as adding new host api with the discovered parameters. look at HostListModel:onSaveInternal when we check the getIsDiscoveredHosts entity. Provisioned host just call the addhost with the details from the host provider Line 102: For host groups: Line 103: Line 104: GET /foremanhostproviders/{provider:id}/hostgroups Line 105: <foreman_host_groups> -- To view, visit http://gerrit.ovirt.org/33969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2144125f00822263dc68da881eb3180c4cd6b237 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
