Lior Vernia has posted comments on this change. Change subject: webadmin: gui for adding macPool permissions. ......................................................................
Patch Set 24: Code-Review+2 (1 comment) Looks great, one small comment inline. http://gerrit.ovirt.org/#/c/32211/24/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacPoolPermissionModelProvider.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacPoolPermissionModelProvider.java: Line 11: Line 12: import com.google.gwt.event.shared.EventBus; Line 13: import com.google.inject.Provider; Line 14: Line 15: public class MacPoolPermissionModelProvider extends PermissionModelProvider<SharedMacPoolListModel>{ Please run formatter on the file... Line 16: Line 17: @Inject Line 18: public MacPoolPermissionModelProvider(EventBus eventBus, Line 19: Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, -- To view, visit http://gerrit.ovirt.org/32211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
