Martin Mucha has posted comments on this change. Change subject: webadmin: gui for adding macPool permissions. ......................................................................
Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/32211/21/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/PermissionModelProvider.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/PermissionModelProvider.java: Line 15: import com.google.gwt.event.shared.EventBus; Line 16: import com.google.inject.Inject; Line 17: import com.google.inject.Provider; Line 18: Line 19: public class PermissionModelProvider extends SearchableTabModelProvider<Permissions, PermissionListModel> { > Please try to implement this class so it can be reused as a subtab provider see this proposal http://gerrit.ovirt.org/#/c/33942/2 Line 20: Line 21: private final Provider<RemoveConfirmationPopupPresenterWidget> removeConfirmPopupProvider; Line 22: private final Provider<PermissionsPopupPresenterWidget> permissionPopupProvider; Line 23: -- To view, visit http://gerrit.ovirt.org/32211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
