Martin Peřina has posted comments on this change. Change subject: tools: Replace log4j with JUL as backend for notifier ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/33774/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java: Line 34: try { Line 35: prop = NotificationProperties.getInstance(); Line 36: Line 37: if (prop.isConfigured(LOG_LEVEL)) { Line 38: JavaLoggingUtils.setLogLevel(prop.getProperty(LOG_LEVEL)); > can we change the default from empty to INFO and always use? There's no need to set always. By default it's INFO using information specified in notified-logging.properties. If user wants to change the defaults, then we will need to specify new level with LOG_LEVEL and after that we need to reconfigure. Line 39: } Line 40: Line 41: prop.validate(); Line 42: notificationService = new NotificationService(prop); http://gerrit.ovirt.org/#/c/33774/4/packaging/conf/notifier-logging.properties.in File packaging/conf/notifier-logging.properties.in: Line 1: # Default logging configuration for oVirt engine notifier Line 2: Line 3: # Set root level to ALL, so it can be changed per handler using command line parameter --log-level Line 4: .level=WARNING > I don't understand the above. No, it sets the default for root logger. Each child logger can override this (see below for org.ovirt.level) Line 5: Line 6: # Default level for org.ovirt logger Line 7: org.ovirt.level=INFO Line 8: http://gerrit.ovirt.org/#/c/33774/4/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 76: # Line 77: # One of FINE, INFO, WARNING, SEVERE. If it's empty, then INFO is used. Line 78: # Line 79: LOG_LEVEL= Line 80: > Can we add option for console output? You can do this by modifying notifier-logging.properties (for development), there's no meaning for user to enable console logging for a daemon. Line 81: #-------------------------------------# Line 82: # Notification Service Configuration: # Line 83: #-------------------------------------# Line 84: # Interval (in seconds) between iterations of dispatching messages to subscribers. Default is 120 seconds. -- To view, visit http://gerrit.ovirt.org/33774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10216f8530e23c43942cdf28fe2cb306d7e6df71 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
