Alon Bar-Lev has posted comments on this change. Change subject: tools: Replaces log4j with JUL as backend for notifier ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/33774/2/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 1054: Line 1055: %files tools -f .mfiles-tools Line 1056: Line 1057: %config %{_sysconfdir}/logrotate.d/ovirt-engine-notifier Line 1058: %config %{engine_etc}/notifier/logging.properties we need to be able to set log level via the notifier configuration and the log file is at /var/log anyway... so no logging properties at /etc Line 1059: %config(noreplace) %{engine_etc}/engine-config/engine-config.conf Line 1060: %config(noreplace) %{engine_etc}/engine-manage-domains/engine-manage-domains.conf Line 1061: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_log}/notifier Line 1062: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_run}/notifier http://gerrit.ovirt.org/#/c/33774/2/packaging/etc/notifier/logging.properties.in File packaging/etc/notifier/logging.properties.in: Line 1: # Root logging level, it can be changed for each logger Line 2: .level=INFO Line 3: Line 4: # Default format of log line is: DATE TIME LEVEL [SOURCE] Message Stacktrace Line 5: java.util.logging.SimpleFormatter.format=%1$tY-%1$tm-%1$td %1$tH:%1$tM:%1$tS,%1$tL %4$-5s [%2$s] %5$s%6$s%n this should be at org.ovirt.engine.core.utils.format no? it more consistent with the design of logging. Line 6: Line 7: # Default logging file Line 8: handlers=java.util.logging.FileHandler Line 9: java.util.logging.FileHandler.append=true http://gerrit.ovirt.org/#/c/33774/2/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py: Line 138: # utils has to be added into boot classpath in order to enable Line 139: # custom formatter JavaLoggingFormatter Line 140: ( Line 141: '-Xbootclasspath/p:%s/modules/common/org/ovirt/engine/core/' Line 142: 'utils/main/utils.jar' this can be at notifier configuration file, or we should ass support Line 143: ) % ( Line 144: self._config.get('ENGINE_USR'), Line 145: ), Line 146: Line 145: ), Line 146: Line 147: ( Line 148: '-Djava.util.logging.config.file=%s/notifier/' Line 149: 'logging.properties' this can be at notifier configuration file Line 150: ) % ( Line 151: self._config.get('ENGINE_ETC'), Line 152: ), Line 153: '-Djboss.modules.write-indexes=false', -- To view, visit http://gerrit.ovirt.org/33774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10216f8530e23c43942cdf28fe2cb306d7e6df71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
