Yair Zaslavsky has posted comments on this change. Change subject: aaa: Suppress compiler warnings for unchecked cast ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33682/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 115: ((HttpServletRequest) req).setAttribute(FiltersHelper.Constants.REQUEST_SCHEMES_KEY, schemes); Line 116: HttpSession session = httpreq.getSession(false); Line 117: Deque<AuthenticationProfile> stack = null; Line 118: if (session != null) { Line 119: stack = (Deque<AuthenticationProfile>)session.getAttribute(STACK_ATTR); Your fix is inconsistent. Either should be on the method, or in the exact place at the method. I prefer the latter Please put the supperswarnings on the session.getAttribute line. Thanks! Line 120: } Line 121: if (stack == null) { Line 122: stack = new ArrayDeque<AuthenticationProfile>(); Line 123: stack.addAll(profiles); -- To view, visit http://gerrit.ovirt.org/33682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetj...@gmail.com> Gerrit-Reviewer: Tim Speetjens <tim.speetj...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
