Maor Lipchuk has posted comments on this change. Change subject: core: Log error correctly when connecting domain for removal ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33442/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java: Line 31: .runInternalAction(VdcActionType.forValue(type), Line 32: new StorageServerConnectionParametersBase(connection, vdsId)); Line 33: result = new Pair<>(returnValue.getSucceeded(), returnValue.getFault()); Line 34: } else { Line 35: result = new Pair<>(false, null); > But I don't want to initialize and then chance it if we get to line 33, poi It will make the code a bit shorter, but it is an implementation detail so not must Line 36: log.warn("Did not connect host: " + vdsId + " to storage domain: " + storageDomain.getStorageName() Line 37: + " because connection for connectionId:" + storageDomain.getStorage() + " is null."); Line 38: } Line 39: return result; -- To view, visit http://gerrit.ovirt.org/33442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
