Tal Nisan has posted comments on this change. Change subject: core: Log error correctly when connecting domain for removal ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33442/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java: Line 18: Line 19: @Override Line 20: public boolean connectStorageToDomainByVdsId(StorageDomain storageDomain, Guid vdsId) { Line 21: return true; Line 22: } > This can be removed - the base class will take care of it. It's parent is StorageHelperBase which actually has this method implemented, unless I'm missing something Line 23: Line 24: @Override Line 25: public boolean disconnectStorageFromDomainByVdsId(StorageDomain storageDomain, Guid vdsId) { Line 26: return true; -- To view, visit http://gerrit.ovirt.org/33442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd7435336acbec41edbdd70568f1dfdce664f875 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
