Yair Zaslavsky has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/33479/14/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java: Line 126: TrustManagerFactory tmf = TrustManagerFactory.getInstance(trustManagerAlgorithm); Line 127: tmf.init(ks); Line 128: tm = tmf.getTrustManagers(); Line 129: } Line 130: } else { > ok... another one... this else should be moved on indent upward. Done Line 131: tm = new TrustManager[] { Line 132: new X509TrustManager() { Line 133: public java.security.cert.X509Certificate[] getAcceptedIssuers() { Line 134: return new java.security.cert.X509Certificate[] {}; -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
