Alon Bar-Lev has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/33479/13/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java: Line 114: return create(null); Line 115: } Line 116: Line 117: Line 118: public HttpURLConnection create(final List<X509Certificate> chain) throws IOException, GeneralSecurityException { > Didn't we agree to remove this, and get the certificates from the HttpsUrlC yes. this comment was before we discussed what it is. Line 119: URLConnection connection = url.openConnection(); Line 120: connection.setAllowUserInteraction(false); Line 121: connection.setUseCaches(false); Line 122: if (readTimeout != null) { -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
