Eliraz Levi has posted comments on this change.

Change subject: engine: adding QoS network name to vmNetworkInterface entity
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/33204/3/packaging/dbscripts/create_views.sql
File packaging/dbscripts/create_views.sql:

Line 983:       vm_interface_statistics.tx_drop, 
vm_interface_statistics.iface_status, vm_interface.type, vm_interface.speed,
Line 984:       vm_interface.mac_addr, network.name AS network_name, 
vm_interface.name, vm_interface.vnic_profile_id, NULL::uuid as vm_guid,
Line 985:       vm_interface.vmt_guid, vm_templates.vm_name AS vm_name, 
vm_interface.id, 0 AS boot_protocol, 0 AS is_vds,
Line 986:       vm_device.is_plugged as is_plugged, vm_device.custom_properties 
as custom_properties, vnic_profiles.port_mirroring AS port_mirroring,
Line 987:       vm_interface.linked, vm_templates.vds_group_id AS vds_group_id, 
vm_templates.entity_type AS vm_entity_type, vnic_profiles.name AS 
vnic_profile_name , qos.name
> please add: "AS qos_name"
Done
Line 988:   FROM vm_interface_statistics
Line 989:   RIGHT JOIN vm_interface ON vm_interface_statistics.id = 
vm_interface.id
Line 990:   JOIN vm_static AS vm_templates ON vm_interface.vmt_guid = 
vm_templates.vm_guid
Line 991:   JOIN vm_device ON vm_interface.vmt_guid = vm_device.vm_id AND 
vm_interface.id = vm_device.device_id


-- 
To view, visit http://gerrit.ovirt.org/33204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to