Moti Asayag has posted comments on this change. Change subject: engine: adding QoS network name to vmNetworkInterface entity ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/33204/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java: Line 140: if (!(obj instanceof VmNetworkInterface)) { Line 141: return false; Line 142: } Line 143: VmNetworkInterface other = (VmNetworkInterface) obj; Line 144: if (!ObjectUtils.objectsEqual(getNetworkName(), other.getNetworkName())) { thanks for this fix, but this bug fix should go into a separate patch since it is not related to this commit. Line 145: return false; Line 146: } Line 147: if (!ObjectUtils.objectsEqual(getVnicProfileName(), other.getVnicProfileName())) { Line 148: return false; http://gerrit.ovirt.org/#/c/33204/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 975: JOIN vm_interface ON vm_interface_statistics.id = vm_interface.id Line 976: JOIN vm_static ON vm_interface.vm_guid = vm_static.vm_guid Line 977: JOIN vm_device ON vm_interface.vm_guid = vm_device.vm_id AND vm_interface.id = vm_device.device_id Line 978: LEFT JOIN (vnic_profiles JOIN network ON network.id = vnic_profiles.network_id) ON vnic_profiles.id = vm_interface.vnic_profile_id Line 979: LEFT JOIN qos ON vnic_profiles.network_qos_id = qos.id note that this left join should go into the join of vnic_profiles and network in the line above Line 980: UNION Line 981: SELECT vm_interface_statistics.rx_rate, vm_interface_statistics.tx_rate, vm_interface_statistics.rx_drop, Line 982: vm_interface_statistics.tx_drop, vm_interface_statistics.iface_status, vm_interface.type, vm_interface.speed, Line 983: vm_interface.mac_addr, network.name AS network_name, vm_interface.name, vm_interface.vnic_profile_id, NULL::uuid as vm_guid, Line 988: RIGHT JOIN vm_interface ON vm_interface_statistics.id = vm_interface.id Line 989: JOIN vm_static AS vm_templates ON vm_interface.vmt_guid = vm_templates.vm_guid Line 990: JOIN vm_device ON vm_interface.vmt_guid = vm_device.vm_id AND vm_interface.id = vm_device.device_id Line 991: LEFT JOIN (vnic_profiles JOIN network ON network.id = vnic_profiles.network_id) ON vnic_profiles.id = vm_interface.vnic_profile_id Line 992: LEFT JOIN qos ON vnic_profiles.network_qos_id = qos.id; same Line 993: Line 994: Line 995: Line 996: ---------------------------------------------- -- To view, visit http://gerrit.ovirt.org/33204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
