Moti Asayag has posted comments on this change. Change subject: tools: CidrValidation Utils ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/32539/12/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/CidrValidatorTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/CidrValidatorTest.java: Line 25: } Line 26: Line 27: @Test Line 28: public void checkCidrFormatValidation() { Line 29: assertEquals("Failed to validate CIDR's Format: " + cidr, validCidrFormatExpectedResult, CidrValidator.getInstance().isCidrFormatValid(cidr));//$NON-NLS-1$ > please remove the //$NON-NLS-1$ from this file. I guess the confusion for the need for it came from: http://gerrit.ovirt.org/#/c/32541/14/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java,cm which resides on the webadmin. Line 30: } Line 31: Line 32: @Test Line 33: public void checkNetworkAddressValidation() { -- To view, visit http://gerrit.ovirt.org/32539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1277dbc815953926fe1648350cd55cb75e1084a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
