Eliraz Levi has posted comments on this change. Change subject: tools: CidrValidation Utils ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/32539/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java: Line 24: * {@link CidrValidator#isCidrFormatValid(String)} Line 25: * @return true if correct format, false otherwise. Line 26: */ Line 27: public boolean isCidrFormatValid(String cidr) { Line 28: return (cidr == null || !cidr.matches(ValidationUtils.CIDR_FORMAT_PATTERN)) ? > it could be replaced only by: Done Line 29: false : true; Line 30: } Line 31: Line 32: /*** -- To view, visit http://gerrit.ovirt.org/32539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1277dbc815953926fe1648350cd55cb75e1084a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
