Shahar Havivi has posted comments on this change. Change subject: engine: boot-protocol for VmInitNetwork ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33199/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java: Line 7: public class VmInitNetwork implements Serializable, BusinessEntity<Guid> { Line 8: private static final long serialVersionUID = 1257388375049806155L; Line 9: private Boolean startOnBoot; Line 10: private String name; Line 11: private NetworkBootProtocol bootProtocol = NetworkBootProtocol.NONE; > please move initialization to the ctor, there is some issue with this kind Done Line 12: private String ip; Line 13: private String netmask; Line 14: private String gateway; Line 15: private Guid id; -- To view, visit http://gerrit.ovirt.org/33199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
